Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support zh-hant for DeepL #711

Merged
merged 3 commits into from
Nov 1, 2024
Merged

feat: support zh-hant for DeepL #711

merged 3 commits into from
Nov 1, 2024

Conversation

tisfeng
Copy link
Owner

@tisfeng tisfeng commented Oct 31, 2024

Close #709

Because DeepL's Source language and Target language are different, Source languages do not support language variants, such as zh-hans, so we need to remove language variants when using Source languages.

DeepL Docs

Copy link
Collaborator

@Jerry23011 Jerry23011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tisfeng tisfeng merged commit 4c6658d into dev Nov 1, 2024
5 checks passed
@tisfeng tisfeng deleted the support-zh-hant-deepl branch November 1, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants